support R 4.0 raw string search #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randy3k
force-pushed
the
raw_string_search
branch
2 times, most recently
from
a008f91 to
587dfbe
Compare
renkun-ken
reviewed
Jul 9, 2020
| state->single_quoted = 0; | ||
| } | ||
| } else if (state->raw_parse_state == 2) { | ||
| if (c == '(' || c == '[' || c == '{') { |
There was a problem hiding this comment.
Looks like | works too (but undocumented at https://stat.ethz.ch/R-manual/R-devel/library/base/html/Quotes.html).
There was a problem hiding this comment.
Do you think we should also support |?
There was a problem hiding this comment.
I guess we should not since it is undocumented behavior.
|
I didn't have time to work on this, so I guess we will skip it for v0.3.7 |
randy3k
force-pushed
the
raw_string_search
branch
from
587dfbe to
a2e97ed
Compare
|
I have decided not to improve multiline support in this PR but rather to merge it first. After merging this PR, I reckon we should freeze the master branch and prepare a release. |
randy3k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
better multiline support