Always running after a deploy, when ssh to server failed! #32
Conversation
Merge the source repo
| $output .= $this->logError($output_line); | ||
| } else { | ||
| $output .= $this->logSuccess($output_line); | ||
| } |
There was a problem hiding this comment.
PHPCS: Whitespace found at end of line
fix phpcs error
fix phpcs error fix phpcs
|
I have fixed the phpcs problem. But the ci is still failed. Why? |
|
I'll merge this in later today, out of interest what SSH server are you using? I still have not managed to recreate this problem, I've tried with a vagrant VM but thought vagrant might be doing something funny so I spun up a new linode and still can't get it to happen (setting .ssh to 600 it does fail to connect but I get the deploy correctly being marked as failed) Don't worry about the CI issue, that is me, PHPCS is still complaining about the complexity of DeployProject.php and I have not got round to refactoring it |
|
All code is running on cent os 7.0 . The target deploy server is the same machine. [liubing@develop ~]$ php -v
PHP 5.6.9 (cli) (built: May 15 2015 09:31:38)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies |
REBELinBLUE
changed the title
This may be is not best way. Because it can't get the real response from the server. Like below.