Improve CI for Linux #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I understand, you're targeting |
Added some comments to the Cross.toml file to provide further information of the glibc version that will be used corresponding with the build image. Additionally, pinned the build image version to 0.2.4-centos.
|
Good point on the build image version, changed that in the most recent commit. I also added some comments which are providing information to the corresponding glibc version and where to find that information. |
|
It's been half a year, and I am no longer interested in this PR. Feel free to use this PR as a starting point if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the build command for the linux-release job to use cross. The linux target gets compiled against
glibcversion2.17, the lowestrust>=1.60itself supports, which should maximize compatibility for many linux distros.If desired, we can also use cross to setup a build using
muslinstead oflibc. According to my testing, a binary built withmusldoesn't work on wayland though, because of this issue.I also implemented a simple
cargo checkworkflow for every platform, which is currently triggered by a push.At the moment, this is an initial draft. Things I would like to improve further are:
cargo clippyon pushcargo fmt --checkon pushIf this PR looks like it is going in the right direction, I'd like to continue working on above points, otherwise I'm open to change the PR according to your needs.