Draft 11 Control Messages #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhasHere
approved these changes
Apr 30, 2025
RichLogan
added
the
not ready
|
How about we do our PRs and get them ready, then let's merge/squash this first followed by each subsequent PR based on their readiness. |
|
Created issue #560 because this PR removed our custom NewGroup message. This is going to be a challenge to use the parser to regenerate control message parsing/handling when we also have custom messages. |
|
@TimEvens Scott already has a mechanism for this, I will regenerate with that now. |
* Add draft 11 subgroup header + logic * Make test case parameterized * Naming * Rename
* Implement new KVP MoQ structure - Add for parameters - Consolidate uint64_t enum coding - Move parameters to new structure * Remove parameter parsing from parser * Update for odd values * Fix decode and tests * Decode to encoded size
Change control message payload size to 16bit
Standardize error reason/reason phrase
Request ID changes
Add ControlMessage encoder
RichLogan
removed
the
not ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.