Add draft parser #531
Merged
Add draft parser #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CMAKE_POLICY_VERSION_MINIMUM to get past doctest having an unsupported cmake verion.
|
Okay - after struggling with compiler differences I think this is ready to have some eyes on it. There are still some comments with my initials ("SAH"). Let you know if you see any issues. There seems to be a lot of changes - but a lot of them are change names. I use the draft as the authoritative source for names. |
Comment on lines
+32
to
+37
| Bytes& operator<<(Bytes& buffer, std::uint64_t value) | ||
| { | ||
| UintVar varint = value; | ||
| buffer << varint; | ||
| return buffer; | ||
| } |
There was a problem hiding this comment.
Do we want to do this? Should we instead wrap integers we want to be uvarint encoded in place?
GhostofCookie
approved these changes
Apr 15, 2025
TimEvens
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to incorporate the draft_parser and its generated code for MOQ Draft number 10.