Skip to content

[[4p, 2(p − 2), 4]] Delfosse-Reichardt repetition code #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Collaborator

@Fe-r-oz Fe-r-oz commented Jan 20, 2025

The paper Short Shor-style syndrome sequences has many interesting generalized quantum codes from base that could be implemented. This PR implements one such code: [[4p, 2(p − 2), 4]] Delfosse repetition code. This is one of the generalized codes that were developed by Delfosse and Reichardt.

Interestingly, ECC Zoo don't have entries for these 'generalized codes' yet. These codes are tested using the test_ecc_base.jl for properties checkup. These codes were defined as [[4p, 2(p − 2), 4]] codes so I named them DelfosseRepCode. Internally, it uses extended blocks of [4,1,4] repetition code which is different in symmetry/structure from the RepCode that is already implemented.

Please find the following schematics for these codes:

display
display

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them.

@Fe-r-oz
Copy link
Collaborator Author

Fe-r-oz commented Jan 21, 2025

What's left is to add some explicit tests so that I can verify stuff from this paper explicitly.

@Fe-r-oz Fe-r-oz marked this pull request as ready for review January 21, 2025 09:57
@Fe-r-oz
Copy link
Collaborator Author

Fe-r-oz commented Jan 21, 2025

P̶l̶e̶a̶s̶e̶ h̶e̶l̶p̶ r̶e̶v̶i̶e̶w̶ t̶h̶i̶s̶ P̶R̶, t̶h̶a̶n̶k̶ y̶o̶u̶!̶

Edit: Documentation needs polish and a small doctest is required so turned it to draft 🙏🏼

@Fe-r-oz Fe-r-oz marked this pull request as draft January 21, 2025 13:25
@Fe-r-oz Fe-r-oz marked this pull request as ready for review January 21, 2025 14:13
@Fe-r-oz
Copy link
Collaborator Author

Fe-r-oz commented Jan 21, 2025

Please help review this PR, thank you!

I updated the documentation, added a docstring that includes [[24,8,4]] Delfosse repetition code.

@Fe-r-oz Fe-r-oz changed the title [[4p, 2(p − 2), 4]] Delfosse repetition code [[4p, 2(p − 2), 4]] Delfosse-Reichardt repetition code Jan 24, 2025
@Fe-r-oz Fe-r-oz marked this pull request as draft February 5, 2025 04:40
@Fe-r-oz Fe-r-oz marked this pull request as ready for review February 20, 2025 06:43
@Fe-r-oz
Copy link
Collaborator Author

Fe-r-oz commented Feb 20, 2025

There were some merge conflicts due to the fixes which got resolved thanks to #479.

Please help review this PR, Thank you!

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.46%. Comparing base (5341f9d) to head (ee49ba4).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/ecc/codes/delfosserepcode.jl 82.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   83.51%   83.46%   -0.05%     
==========================================
  Files          72       73       +1     
  Lines        4804     4833      +29     
==========================================
+ Hits         4012     4034      +22     
- Misses        792      799       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fe-r-oz Fe-r-oz added the ECC Having to do with the ECC submodule label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECC Having to do with the ECC submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant