Fix issues reported by JET

[lgoettgens]

Resolves #307.

• The code is properly formatted and commented.
• Substantial new functionality is documented within the docs.
• All new functionality is tested.
• All of the automated tests on github pass.
• We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them.

[lgoettgens]

This is good to go from my POV @Krastanov

[Krastanov]

This looks great, thank you! It will probably take me a couple of days to get around to completely reviewing it. I am curious about one particular point:

I see that in a lot of places you have changed old historic code like x.rank to much neater and idiomatic rank(x). That is great, but I am curious why did that have an effect on the amount of JET warnings. Do you have a brief explanation?

[lgoettgens]

I see that in a lot of places you have changed old historic code like x.rank to much neater and idiomatic rank(x). That is great, but I am curious why did that have an effect on the amount of JET warnings. Do you have a brief explanation?

In an in-between version while fiddling around with some reports, I thought that one JET report was due to badly inferred .tab (or .rank, don't remember it exactly). My "solution" was to add a type assertion to a tab(::Dunno) return value, and update the call-sites to use this getter instead of direct field access. It turned out that the JET issue was resolved by some other change on its own, but I thought I'll just keep this improvement in the PR.

[codecov]

Codecov Report

Attention: Patch coverage is 83.56164% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (be50f9c) to head (145185b).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/tableau_show.jl	53.84%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   83.06%   83.03%   -0.03%     
==========================================
  Files          70       70              
  Lines        4410     4410              
==========================================
- Hits         3663     3662       -1     
- Misses        747      748       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Krastanov]

Thank you, this is very much appreciated! This should be merged soon, just waiting on a final round of tests. I submitted the final list of bounties to NumFOCUS this week, and I will try to add this one as well, but there is a chance they will have to process it in the next round.

[Krastanov]

I merged master in here because there was a bug in LinearAlgebra 1.11.1 that we were hitting. The master branch has the workaround.

[lgoettgens]

Thank you, this is very much appreciated! This should be merged soon, just waiting on a final round of tests. I submitted the final list of bounties to NumFOCUS this week, and I will try to add this one as well, but there is a chance they will have to process it in the next round.

Thanks!