Skip to content

Compatibility with MultiTensorKit #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 19, 2025

Conversation

borisdevos
Copy link
Contributor

This PR contains the necessary changes within TensorKitSectors to be compatible with MultiTensorKit. It comes down to evaluating left and right units within F-symbols.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/sectors.jl 71.42% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/TensorKitSectors.jl 20.00% <ø> (ø)
src/sectors.jl 83.68% <71.42%> (+0.23%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the docstring issue I'm okay with merging this.

Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jutho do you have any comments here or can I merge (and tag) this?

@Jutho
Copy link
Member

Jutho commented Mar 18, 2025

I haven't checked the math, so the occurence of leftone and rightone in these definitions, but I assume that this is what @borisdevos has tested extensively, so I am definitely fine with merging this.

@lkdvos lkdvos merged commit 87c3c85 into QuantumKitHub:main Mar 19, 2025
7 of 8 checks passed
@borisdevos borisdevos deleted the boris-multitensorkit branch March 19, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants