Skip to content

Add fallback definitions for getindex(::SectorValues) and findindex(::SectorValues) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2025
Merged

Add fallback definitions for getindex(::SectorValues) and findindex(::SectorValues) #6

merged 3 commits into from
Jan 2, 2025

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Jan 2, 2025

Closes #5

@Jutho
Copy link
Member

Jutho commented Jan 2, 2025

It seems some of the existing getindex methods don't typefix the i argument, thus leading to ambiguities.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/sectors.jl 78.57% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/anyons.jl 85.00% <100.00%> (ø)
src/fermions.jl 64.28% <100.00%> (ø)
src/sectors.jl 78.94% <78.57%> (-0.05%) ⬇️

@Jutho Jutho self-requested a review January 2, 2025 14:56
@lkdvos lkdvos merged commit e6ee869 into main Jan 2, 2025
8 checks passed
@lkdvos lkdvos deleted the getindex branch January 2, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jutho Jutho Jutho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterating values(::ProductSector) fails if getindex is not defined for one of the factors
2 participants
@lkdvos @Jutho