speedup isless productsector #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, it is simpler than that; there is no such recursive structure. The order is just in terms of increasing total Manhattan distance, and within the same Manhattan distance it is simply lexographic ordering of the multidimensional index. |
lkdvos
approved these changes
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
I am not quite sure why JET is complaining on Julia 1.11.1. I won't have much time to look into it until later today. |
|
Ok I fixed the JET complaints by adding some type restrictions/specialisations. It seems very un-Julian that this is necessary, but I guess that for now it is without harm. |
|
Also, I don't know why Julia 1.10 ubuntu-latest x64 CI is not running/reporting. Is this some rule you set up @lkdvos ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than computing the Manhattan index for defining
isless, use that the Manhattan index is increasing in such a way that multidimensional indices are sorted first according to total manhattan distance to the origin, then among those with fixed total manhattan distance, sorted according to manhattan distance of the first N-1 indices, and so forth.