-
Notifications
You must be signed in to change notification settings - Fork 22
Fix example caching checksum
#227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm also rerunning all the examples to generate a new |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
Co-authored-by: Lukas Devos <[email protected]>
I'll rerun all the examples again once #226 is merged so the rendered output doesn't show the warnings. |
Not quite related to this PR, but I notice that the AD part of J1-J2 example
Then, at step 97, the imaginary part of the measured energy (
Before #219 we don't have these warnings. The initial state produced by SU right now is more C4v symmetric, but the energy is slightly higher than before. @pbrehmer Can you try tweaking the AD parameters (e.g. use |
Thanks for pointing that out, I'll take a look! Update: Using |
It took some extra effort to get it below the YASTN estimate again - I had to add some noise to the SU PEPS to break some of the C4v symmetry. The optimization will get stuck too at some point (as expected) but it can converge to a lower energy. This would be good to go for me now! |
Here we fix
checksum
such that it generates a hex code from a path relative to the PEPSKit project directory.Previously,
checksum
would just use@__DIR__
which would be the full absolute path. This had the consequence that different users needed to rerun already cached examples.