Skip to content

Documentation update #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 129 commits into from
May 5, 2025
Merged

Documentation update #161

merged 129 commits into from
May 5, 2025

Conversation

leburgel
Copy link
Member

@leburgel leburgel commented Mar 19, 2025

To do

Examples

  • A simple Heisenberg example that can serve as a "getting started" example which shows basics of optimization, CTMRG contraction, computing the correlation length and observables
  • Example showing how to use fermionic tensors and that optimizing them might require different settings
  • Example showcasing $\mathbb{Z}_2$ or $U(1)$ symmetric optimization
  • Example or part of an example which shows how to use gradient_alg=nothing (POSTPONED)
  • Boundary MPS example using VUMPS to contract a PEPS
  • Example with PEPS-PEPO-PEPS contraction
  • Example for contracting a partition function
  • A simple update (and in the future NTU/full update) example

https://quantumkithub.github.io/PEPSKit.jl/previews/PR161/

@leburgel leburgel marked this pull request as draft March 19, 2025 10:59
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/operators/localoperator.jl 62.50% 3 Missing ⚠️
src/algorithms/ctmrg/sparse_environments.jl 0.00% 2 Missing ⚠️
src/states/infiniteweightpeps.jl 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/Defaults.jl 85.71% <ø> (ø)
src/PEPSKit.jl 100.00% <ø> (ø)
src/algorithms/contractions/bondenv/als_solve.jl 100.00% <ø> (ø)
src/algorithms/contractions/ctmrg_contractions.jl 58.09% <ø> (ø)
src/algorithms/contractions/localoperator.jl 94.94% <ø> (ø)
src/algorithms/ctmrg/ctmrg.jl 90.47% <ø> (ø)
src/algorithms/ctmrg/gaugefix.jl 97.19% <ø> (ø)
src/algorithms/ctmrg/projectors.jl 82.69% <ø> (ø)
src/algorithms/ctmrg/sequential.jl 98.36% <ø> (ø)
src/algorithms/ctmrg/simultaneous.jl 98.27% <ø> (ø)
... and 24 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pbrehmer
Copy link
Collaborator

pbrehmer commented Mar 19, 2025

Here are some TODOs for the documentation update from our last meeting but also things that came to my mind recently:

In terms of examples that we want to add to the docs, I think we suggested the following (noting that most of these already exist in the examples folder and only need to be converted to a notebook with some additional explanations):

  • A simple Heisenberg example that can serve as a "getting started" example which shows basics of optimization, CTMRG contraction, computing the correlation length and observables
  • Example showing how to use fermionic tensors and that optimizing them might require different settings
  • Example showcasing $\mathbb{Z}_2$ or $U(1)$ symmetric optimization
  • Example or part of an example which shows how to use gradient_alg=nothing
  • Boundary MPS example using VUMPS to contract a PEPS
  • Example with PEPS-PEPO-PEPS contraction
  • A simple update (and in the future NTU/full update) example

Feel free to add suggestions and ideas to the above lists!

@lkdvos
Copy link
Member

lkdvos commented Mar 19, 2025

I added the list to the PR description, apologies if I'm putting words in @leburgel 's mouth but that seems a bit easier to track and less likely to get lost 😉

@leburgel
Copy link
Member Author

@lkdvos lkdvos added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Mar 20, 2025
Copy link
Contributor

After the build completes, the updated documentation will be available here

Nothing to see here, this definitely worked first attempt

- attempt II

- attempt III

- Attempt whatever

- yaml is a great language
@lkdvos lkdvos force-pushed the lb/docs_infrastructure branch from ce85a94 to 8b23dc0 Compare March 20, 2025 15:34
@lkdvos
Copy link
Member

lkdvos commented Mar 20, 2025

It would be great if we can all pretend I nailed that first attempt

@pbrehmer
Copy link
Collaborator

pbrehmer commented May 1, 2025

This is mostly done from my part. I will rerun the examples and update the cache fully once I get access to a more powerful computer again (I'm currently only on my laptop). But if someone else wants to do that, feel free to do so :-)

@leburgel perhaps you could finish the suggestions for the 3D Ising model? Otherwise this PR would be good to go for me! Thanks again for the comprehensive review.

@leburgel
Copy link
Member Author

leburgel commented May 5, 2025

I addressed the remaining comments for the 3D classical Ising example I think. As far as I'm concerned, we can update the cache again and merge.

@pbrehmer
Copy link
Collaborator

pbrehmer commented May 5, 2025

I'm just rerunning the examples right now, so I'll push the updated rendered examples and cache, and then I'd be fine with merging as well.

@pbrehmer
Copy link
Collaborator

pbrehmer commented May 5, 2025

Alright, good to go for me once the tests run through :-) @lkdvos What do you think? Also, shall we tag a new release after merging this?

@lkdvos
Copy link
Member

lkdvos commented May 5, 2025

I'll have breakfast and quickly go through it one last time, but I think I gave my comments in the last round so should be good to go. Agreed with the version update as well, but let's keep that as a separate commit so I can also double check what changed.

@lkdvos lkdvos merged commit b9fdb95 into master May 5, 2025
39 checks passed
@lkdvos lkdvos deleted the lb/docs_infrastructure branch May 5, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants