-
Notifications
You must be signed in to change notification settings - Fork 16
Documentation update #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update #161
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Here are some TODOs for the documentation update from our last meeting but also things that came to my mind recently:
In terms of examples that we want to add to the docs, I think we suggested the following (noting that most of these already exist in the examples folder and only need to be converted to a notebook with some additional explanations):
Feel free to add suggestions and ideas to the above lists! |
I added the list to the PR description, apologies if I'm putting words in @leburgel 's mouth but that seems a bit easier to track and less likely to get lost 😉 |
After the build completes, the updated documentation will be available here |
Nothing to see here, this definitely worked first attempt - attempt II - attempt III - Attempt whatever - yaml is a great language
ce85a94
to
8b23dc0
Compare
It would be great if we can all pretend I nailed that first attempt |
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
Co-authored-by: Lukas Devos <[email protected]>
This is mostly done from my part. I will rerun the examples and update the cache fully once I get access to a more powerful computer again (I'm currently only on my laptop). But if someone else wants to do that, feel free to do so :-) @leburgel perhaps you could finish the suggestions for the 3D Ising model? Otherwise this PR would be good to go for me! Thanks again for the comprehensive review. |
I addressed the remaining comments for the 3D classical Ising example I think. As far as I'm concerned, we can update the cache again and merge. |
I'm just rerunning the examples right now, so I'll push the updated rendered examples and cache, and then I'd be fine with merging as well. |
…Kit.jl into lb/docs_infrastructure
Alright, good to go for me once the tests run through :-) @lkdvos What do you think? Also, shall we tag a new release after merging this? |
I'll have breakfast and quickly go through it one last time, but I think I gave my comments in the last round so should be good to go. Agreed with the version update as well, but let's keep that as a separate commit so I can also double check what changed. |
To do
Examples
gradient_alg=nothing
(POSTPONED)https://quantumkithub.github.io/PEPSKit.jl/previews/PR161/