Skip to content

CompatHelper: bump compat for OptimKit to 0.4, (keep existing compat) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2025
Merged

CompatHelper: bump compat for OptimKit to 0.4, (keep existing compat) #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f5829e
CompatHelper: bump compat for OptimKit to 0.4, (keep existing compat)
Jan 28, 2025
fe015a4
Merge branch 'master' into compathelper/new_version/2025-01-28-01-10-…
lkdvos Jan 28, 2025
31d733a
Merge branch 'master' into compathelper/new_version/2025-01-28-01-10-…
lkdvos Jan 28, 2025
cc72e54
Update random seed and default LBFGS verbosity
pbrehmer Jan 31, 2025
e74e655
Remove sandbox file
pbrehmer Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ LoggingExtras = "1"
MPSKit = "0.12"
MPSKitModels = "0.4"
OhMyThreads = "0.7"
OptimKit = "0.3"
OptimKit = "0.3, 0.4"
Printf = "1"
QuadGK = "2.11.1"
Random = "1"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ chi = 20
ctm_alg = SimultaneousCTMRG(; tol=1e-10, trscheme=truncdim(chi))
opt_alg = PEPSOptimize(;
boundary_alg=ctm_alg,
optimizer=LBFGS(4; maxiter=100, gradtol=1e-4, verbosity=2),
optimizer=LBFGS(4; maxiter=100, gradtol=1e-4, verbosity=3),
gradient_alg=LinSolver(),
reuse_env=true,
)
Expand Down
2 changes: 1 addition & 1 deletion docs/src/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ chi = 20
ctm_alg = SimultaneousCTMRG(; tol=1e-10, trscheme=truncdim(chi))
opt_alg = PEPSOptimize(;
boundary_alg=ctm_alg,
optimizer=LBFGS(4; maxiter=100, gradtol=1e-4, verbosity=2),
optimizer=LBFGS(4; maxiter=100, gradtol=1e-4, verbosity=3),
gradient_alg=LinSolver(),
reuse_env=true,
)
Expand Down
2 changes: 1 addition & 1 deletion examples/heisenberg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ H = heisenberg_XYZ(InfiniteSquare(); Jx=-1, Jy=1, Jz=-1)
ctm_alg = SimultaneousCTMRG(; tol=1e-10, verbosity=2)
opt_alg = PEPSOptimize(;
boundary_alg=ctm_alg,
optimizer=LBFGS(4; maxiter=100, gradtol=1e-4, verbosity=2),
optimizer=LBFGS(4; maxiter=100, gradtol=1e-4, verbosity=3),
gradient_alg=LinSolver(; solver=GMRES(; tol=1e-6, maxiter=100)),
reuse_env=true,
)
Expand Down
4 changes: 2 additions & 2 deletions src/PEPSKit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ include("utility/symmetrization.jl")
const ctmrg_alg = SimultaneousCTMRG(
ctmrg_tol, ctmrg_maxiter, ctmrg_miniter, 2, projector_alg
)
const optimizer = LBFGS(32; maxiter=100, gradtol=1e-4, verbosity=2)
const optimizer = LBFGS(32; maxiter=100, gradtol=1e-4, verbosity=3)
const gradient_linsolver = KrylovKit.BiCGStab(;
maxiter=Defaults.fpgrad_maxiter, tol=Defaults.fpgrad_tol
)
Expand Down Expand Up @@ -130,7 +130,7 @@ module Defaults
const ctmrg_alg = SimultaneousCTMRG(
ctmrg_tol, ctmrg_maxiter, ctmrg_miniter, 2, projector_alg
)
const optimizer = LBFGS(32; maxiter=100, gradtol=1e-4, verbosity=2)
const optimizer = LBFGS(32; maxiter=100, gradtol=1e-4, verbosity=3)
const gradient_linsolver = KrylovKit.BiCGStab(;
maxiter=Defaults.fpgrad_maxiter, tol=Defaults.fpgrad_tol
)
Expand Down
2 changes: 1 addition & 1 deletion test/heisenberg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Dbond = 2
χenv = 16
ctm_alg = SimultaneousCTMRG()
opt_alg = PEPSOptimize(;
boundary_alg=ctm_alg, optimizer=LBFGS(4; gradtol=1e-3, verbosity=2)
boundary_alg=ctm_alg, optimizer=LBFGS(4; gradtol=1e-3, verbosity=3)
)
# compare against Juraj Hasik's data:
# https://github.com/jurajHasik/j1j2_ipeps_states/blob/main/single-site_pg-C4v-A1/j20.0/state_1s_A1_j20.0_D2_chi_opt48.dat
Expand Down
2 changes: 1 addition & 1 deletion test/j1j2_model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ using OptimKit
ctm_alg = SimultaneousCTMRG()
opt_alg = PEPSOptimize(;
boundary_alg=ctm_alg,
optimizer=LBFGS(4; gradtol=1e-3, verbosity=2),
optimizer=LBFGS(4; gradtol=1e-3, verbosity=3),
gradient_alg=LinSolver(; iterscheme=:diffgauge),
)

Expand Down
2 changes: 1 addition & 1 deletion test/pwave.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ H = pwave_superconductor(InfiniteSquare(unitcell...))
χenv = 16
ctm_alg = SimultaneousCTMRG(; maxiter=150)
opt_alg = PEPSOptimize(;
boundary_alg=ctm_alg, optimizer=LBFGS(4; maxiter=10, gradtol=1e-3, verbosity=2)
boundary_alg=ctm_alg, optimizer=LBFGS(4; maxiter=10, gradtol=1e-3, verbosity=3)
)

# initialize states
Expand Down
4 changes: 2 additions & 2 deletions test/tf_ising.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ mˣ = 0.91
χenv = 16
ctm_alg = SimultaneousCTMRG()
opt_alg = PEPSOptimize(;
boundary_alg=ctm_alg, optimizer=LBFGS(4; gradtol=1e-3, verbosity=2)
boundary_alg=ctm_alg, optimizer=LBFGS(4; gradtol=1e-3, verbosity=3)
)

# initialize states
H = transverse_field_ising(InfiniteSquare(); g)
Random.seed!(91283219347)
Random.seed!(2928528935)
psi_init = InfinitePEPS(2, χbond)
env_init = leading_boundary(CTMRGEnv(psi_init, ComplexSpace(χenv)), psi_init, ctm_alg)

Expand Down