Rewrite rule to remove redundant constants #251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaihsin
changed the title
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
☂️ Python Coverage
Overall Coverage
New Files
Modified FilesNo covered modified files...
|
|
can you explain why your implementation address GVN and not the same as CSE? It seems to me the test case you propose here can also be eliminated by CSE? |
|
oh right, this is covered by CSE. At some point the constant did not get CSE. Then let's close this one. Also, I think the second test example catch a bug in CSE. (but let's deal it in another PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add rewrite pass to eliminate redundant Constant.
Related #239