Skip to content

Allow include "qelib1.inc" when lowering QASM2 string #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Feb 7, 2025

If we don't this makes parsing import QASM a bit annoying for the simulator.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-07 17:48 UTC

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bloqade/qasm2/parse/lowering.py 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Feb 7, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3556 3099 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/qasm2/parse/lowering.py 63% 🟢
TOTAL 63% 🟢

updated for commit: 401b252 by action🐍

@weinbe58 weinbe58 requested a review from Roger-luo February 7, 2025 16:53
Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I understand this special casing, we should still have the right include at some point tho...

@weinbe58 weinbe58 merged commit de49480 into main Feb 7, 2025
8 of 9 checks passed
@weinbe58 weinbe58 deleted the phil/simulator-updates branch February 7, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants