Use # field operator for private fields #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you absolutely want to disallow code to touch a variable, then using the Performance-wise it shouldn't be too big of a difference according to this response What other reasoning would you have to use one over the other? |
Thanks for the research. Let's go for it. If we face issues along the way, we can always reverse things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general I'm not sure if I would like to use the
#field operator, but hiding the underlying field for string based SVO's is key. So also making them private in the ECMAScript (runtime) context, rather then only within the TypeScript (design-time) context makes sense.See microsoft/TypeScript#31670