Skip to content

Fix display of Box End after transpile in text drawer #14278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
May 2, 2025
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
08a23c5
Fix typing-extensions
enavarro51 Jan 4, 2024
8d06451
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jan 4, 2024
f70314a
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jan 12, 2024
c179d5b
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jan 31, 2024
83972c6
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Feb 2, 2024
e6d975c
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Feb 6, 2024
d698cac
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Feb 11, 2024
415504a
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Feb 14, 2024
b0e6690
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Feb 25, 2024
f0731e6
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Mar 5, 2024
e5c951b
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Mar 15, 2024
2de1ea6
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Mar 18, 2024
e815358
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Apr 9, 2024
8a3fff9
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Apr 16, 2024
ddeea5a
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Apr 16, 2024
eabb707
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Apr 25, 2024
ee27daa
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 May 6, 2024
46085a7
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jun 3, 2024
4eb3b78
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jun 14, 2024
9abb225
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jun 28, 2024
c37196e
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jul 3, 2024
809d16a
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Jul 3, 2024
f06bccc
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 Sep 12, 2024
5167c90
Merge branch 'main' of https://github.com/Qiskit/qiskit-terra into main
enavarro51 May 1, 2025
8596cdf
Fix text drawer flow end display
enavarro51 May 1, 2025
530ad51
Lint
enavarro51 May 1, 2025
42d5e53
Add reno
jakelishman May 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qiskit/visualization/circuit/text.py
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,7 @@ def lookup_var(var):
layers.append(flow_layer2.full_layer)

# Draw the right box for End
flow_layer = self.draw_flow_box(node, flow_wire_map, CF_RIGHT, conditional=False)
flow_layer = self.draw_flow_box(node, wire_map, CF_RIGHT, conditional=False)
layers.append(flow_layer.full_layer)

def draw_flow_box(self, node, flow_wire_map, section, circ_num=0, conditional=False):
Expand Down
29 changes: 29 additions & 0 deletions test/python/visualization/test_circuit_text_drawer.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,35 @@ def test_wire_order(self):
expected,
)

def test_box_end_after_transpile(self):
"""Test that drawing a `box` doesn't explode."""
# The exact output is not important - feel free to change it. We only care that it doesn't
# explode when drawing.
qc = QuantumCircuit(5)
qc = QuantumCircuit(4)
with qc.box():
qc.cx(0, 1)
qc.cx(0, 3)

qc_ = transpile(qc, initial_layout=[2, 3, 1, 0])
# We don't care about trailing whitespace on a line.
actual = "\n".join(
line.rstrip() for line in str(qc_.draw("text", fold=80, idle_wires=True)).splitlines()
)

expected = """\
┌─────── ┌───┐ ───────┐
q_3 -> 0 ┤ ─────┤ X ├ ├─
│ └─┬─┘ │
q_2 -> 1 ┤ ───────┼── ├─
│ Box-0 │ End-0 │
q_0 -> 2 ┤ ──■────■── ├─
│ ┌─┴─┐ │
q_1 -> 3 ┤ ┤ X ├───── ├─
└─────── └───┘ ───────┘
""".rstrip()
self.assertEqual(actual, expected)

def test_basic_box(self):
"""Test that drawing a `box` doesn't explode."""
# The exact output is not important - feel free to change it. We only care that it doesn't
Expand Down