Skip to content

IQP migration followup #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 4, 2025
Merged

IQP migration followup #2269

merged 11 commits into from
Jun 4, 2025

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 28, 2025 •
edited
Loading

Summary

  • If there is no instance passed in at initialization, the service cannot make any api calls unless backend() or backends() is called first. In this case we need to load all instances during initialization.
  • Fixed a bug where if use_fractional_gates is set but the backend configuration was already cached, the incorrect configuration could be returned.

Details and comments

Fixes #2272
Fixes #2271

@kt474 kt474 changed the title Fix case where there is no account instance IQP migration followup May 29, 2025
@ElePT ElePT added this to the 0.41.0 milestone Jun 3, 2025
@ElePT ElePT mentioned this pull request Jun 3, 2025
Closed
1 task
ElePT
ElePT reviewed Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes look good to me, but I would like to include a regression test for #2271 too.

kt474
kt474 commented Jun 3, 2025
View reviewed changes
@kt474 kt474 requested a review from ElePT June 3, 2025 17:45
ElePT
ElePT approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 added this pull request to the merge queue Jun 4, 2025
Merged via the queue into Qiskit:main with commit 3a8d49c Jun 4, 2025
17 checks passed
@kt474 kt474 deleted the iqp-followup branch June 4, 2025 15:37
kt474 added a commit that referenced this pull request Jun 4, 2025
@kt474
IQP migration followup (#2269)
759b30d 
* new iqp followup

* remove print

* fix use_fractional_gates bug

* add reno & fix tests

* add tests

* add test & update url logic

* update fg test
@ElePT ElePT modified the milestones: 0.41.0, 0.40.1 Jun 5, 2025
@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
0.40.1
Development

Successfully merging this pull request may close these issues.

Fail to get a backend with fractional gate with qiskit-ibm-runtime 0.40.0 Allow getting a Job by ID without specifying an instance
2 participants
@kt474 @ElePT