Skip to content

Add high-level function for SQD #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
May 30, 2025
Merged

Add high-level function for SQD #195

merged 38 commits into from
May 30, 2025

Conversation

kevinsung
Copy link
Collaborator

@kevinsung kevinsung commented Apr 29, 2025

Fixes #191
Fixes #192
Fixes #182
Fixes #113
Fixes #189 (remaining work tracked at #204 and #205)

@kevinsung kevinsung marked this pull request as draft April 29, 2025 14:39
@caleb-johnson
Copy link
Collaborator

Thanks @kevinsung , if we want to resolve #189 I think we'd want to go through all the notebooks where we run this loop (e.g. orbital optimization how-to, ...) and take the min occupancies there too, right?

@kevinsung
Copy link
Collaborator Author

Thanks @kevinsung , if we want to resolve #189 I think we'd want to go through all the notebooks where we run this loop (e.g. orbital optimization how-to, ...) and take the min occupancies there too, right?

Ok sure, we can do that separately. I no longer marked this PR as closing that issue.

@kevinsung kevinsung marked this pull request as ready for review April 29, 2025 20:53
@kevinsung kevinsung marked this pull request as draft April 29, 2025 20:54
@kevinsung kevinsung marked this pull request as ready for review April 29, 2025 21:34
@kevinsung
Copy link
Collaborator Author

@caleb-johnson I've updated the two tutorials, but I'd like you to review the code and make sure you're okay with it before I update the rest of the documentation to use this high-level function.

@kevinsung kevinsung marked this pull request as draft April 30, 2025 00:29
Copy link
Collaborator

@jrm874 jrm874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new additions look good to me!

I have added a couple of comments regarding some variable/function names

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin, this is looking good! I left a few comments and will continue to review

@kevinsung
Copy link
Collaborator Author

@kevinsung kevinsung marked this pull request as ready for review May 16, 2025 20:31
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great, nice work. Thanks! 🚀

Just a couple of very minor suggestions/comments

@caleb-johnson
Copy link
Collaborator

Tutorials:

  • We could just link out to the API docs for your new high level function and lean up the arg descriptions on both tutorials quite a bit
  • "Note: Qiskit Aer is required to simulate samples from transpiled circuits."
    • You're using Runtime here, I think we can delete this old comment now
  • Regardless of how you feel about bullet 1, I think tutorial 2 needs some arg descriptions for the high level function, even if you just link back to tutorial 1 (or API docs)

@kevinsung
Copy link
Collaborator Author

We could just link out to the API docs for your new high level function and lean up the arg descriptions on both tutorials quite a bit

Done.

"Note: Qiskit Aer is required to simulate samples from transpiled circuits."
You're using Runtime here, I think we can delete this old comment now

Actually, Qiskit Aer is still required. If it's not installed, the following error is raised:

BasicProviderError: 'Number of qubits 127 is greater than maximum (24) for "basic_simulator".'

Regardless of how you feel about bullet 1, I think tutorial 2 needs some arg descriptions for the high level function, even if you just link back to tutorial 1 (or API docs)

I just did the same thing I did for Tutorial 1 and linked to the API docs.

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!! 🚀

@kevinsung kevinsung merged commit ad90961 into Qiskit:main May 30, 2025
13 checks passed
@kevinsung kevinsung deleted the run-sqd branch May 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants