-
Notifications
You must be signed in to change notification settings - Fork 15
Add high-level function for SQD #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @kevinsung , if we want to resolve #189 I think we'd want to go through all the notebooks where we run this loop (e.g. orbital optimization how-to, ...) and take the min occupancies there too, right? |
Ok sure, we can do that separately. I no longer marked this PR as closing that issue. |
@caleb-johnson I've updated the two tutorials, but I'd like you to review the code and make sure you're okay with it before I update the rest of the documentation to use this high-level function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new additions look good to me!
I have added a couple of comments regarding some variable/function names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kevin, this is looking good! I left a few comments and will continue to review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great, nice work. Thanks! 🚀
Just a couple of very minor suggestions/comments
Tutorials:
|
Done.
Actually, Qiskit Aer is still required. If it's not installed, the following error is raised:
I just did the same thing I did for Tutorial 1 and linked to the API docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!! 🚀
Fixes #191
Fixes #192
Fixes #182
Fixes #113
Fixes #189 (remaining work tracked at #204 and #205)