Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Estimator interface to OBP. This allows the user to compute expectation values using
qiskit_addon_obp.backpropagate
. This interface allows for arbitrarily shapedEstimatorPub
s, handles parameter bindings, etc.There are likely some remaining questions before this should be merged if at all, but IMO an Estimator interface of some sort is a natural addition.
For example, currently: if the remaining circuit after backpropagation is non-empty, the
OBPEstimator
will raise aNotImplementedError
. I left a comment with a potential suggestion for how to handle this case:Usage