This repository was archived by the owner on Apr 5, 2025. It is now read-only.
Clean up some typing syntax #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using ruff and stricter pyright settings. Will have to remove later.
- Leave two extra pyright settings on — they can't hurt, right?
AbstractUmbra
suggested changes
Nov 8, 2023
- Not as sure on the relative import change. In my opinion, this is a clearer indicator of where the imports are coming from, is more consistent with similar imports in other files, and doesn't run the risk of messing with an import of builtin types module, unlikely as that is to happen. Might be a matter of style though.
|
Maybe more could be done, but this feels like it could be enough for a PR that doesn't add functionality. |
AbstractUmbra
approved these changes
Nov 13, 2023
|
Has this been tested in terms of actually being able to be ran? With like simple.py or something? |
Yep. It works fine with simple.py on my machine, though I didn't run it exhaustively — I loaded up "Ocean Drive" and a "Rock Classics" Spotify playlist (courtesy of the examples in the migrating docs) and just let it go for a while. |
EvieePy
approved these changes
Nov 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, this doesn't result in any change to the functionality; it's more about making the typing syntax consistent with python 3.10+ and ensuring pyright flags it accordingly if it isn't.