Skip to content

OTT-1876: Select maximum floor from imp.bidfloor and adunit floor for applovinmax endpoint #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 3, 2024
Merged

OTT-1876: Select maximum floor from imp.bidfloor and adunit floor for applovinmax endpoint #829

merged 9 commits into from
Jul 3, 2024

Conversation

pm-jaydeep-mohite
Copy link
Collaborator

@pm-jaydeep-mohite pm-jaydeep-mohite commented Jun 27, 2024 •
edited
Loading

Description

For AppLovinMax endpoint, select maximum floor value from imp.bidfloor and adunitfloor based on feature level flag

Checklist:

  • PR commit list is unique (rebase/pull with the origin branch to keep master clean).
  • JIRA number is added in the PR title and the commit message.
  • Updated the header-bidding repo with appropiate commit id.
  • Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

AvinashKapre
AvinashKapre reviewed Jun 27, 2024
View reviewed changes
pm-saurabh-narkhede
pm-saurabh-narkhede reviewed Jun 27, 2024
View reviewed changes
AvinashKapre
AvinashKapre reviewed Jul 1, 2024
View reviewed changes
AvinashKapre
AvinashKapre reviewed Jul 1, 2024
View reviewed changes
AvinashKapre
AvinashKapre reviewed Jul 1, 2024
View reviewed changes
pm-nikhil-vaidya
pm-nikhil-vaidya reviewed Jul 2, 2024
View reviewed changes
pm-nikhil-vaidya
pm-nikhil-vaidya reviewed Jul 2, 2024
View reviewed changes
pm-nikhil-vaidya
pm-nikhil-vaidya reviewed Jul 2, 2024
View reviewed changes
pm-nikhil-vaidya
pm-nikhil-vaidya reviewed Jul 2, 2024
View reviewed changes
pm-nikhil-vaidya
pm-nikhil-vaidya reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@pm-nikhil-vaidya pm-nikhil-vaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added some minor comments

@pm-jaydeep-mohite pm-jaydeep-mohite merged commit 9622a8d into ci Jul 3, 2024
2 checks passed
pm-nikhil-vaidya added a commit that referenced this pull request Jul 3, 2024
@pm-nikhil-vaidya
Revert "OTT-1876: Select maximum floor from imp.bidfloor and adunit f…
c753eee 
…loor for applovinmax endpoint (#829)"

This reverts commit 9622a8d.

Reverting max floor changes for perf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-nikhil-vaidya pm-nikhil-vaidya pm-nikhil-vaidya approved these changes

@Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil Pubmatic-Supriya-Patil approved these changes

@pm-saurabh-narkhede pm-saurabh-narkhede Awaiting requested review from pm-saurabh-narkhede

@AvinashKapre AvinashKapre Awaiting requested review from AvinashKapre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pm-jaydeep-mohite @pm-nikhil-vaidya @pm-saurabh-narkhede @AvinashKapre @Pubmatic-Supriya-Patil