UOE-8632: refactor URL macro replacer to reduce mem allocs #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm-nilesh-chate
force-pushed
the
UOE-8632-ci-1
branch
from
611c595 to
377d385
Compare
pm-nilesh-chate
changed the title
pm-nilesh-chate
force-pushed
the
UOE-8632-ci-1
branch
from
377d385 to
15c10ca
Compare
| func replaceMacro(trackerURL, macro, value string) string { | ||
| macro = strings.TrimSpace(macro) | ||
| trimmedValue := strings.TrimSpace(value) | ||
| func replaceMacros(trackerURL string, macroMap map[string]string) string { |
There was a problem hiding this comment.
Can you try using Macro Replacer from macros package and check if we get similar benchmark result?
pm-viral-vala
previously approved these changes
Sep 1, 2023
| trackingEle.CreateAttr("event", event) | ||
| trackingEle.SetText(fmt.Sprintf("%s", url)) | ||
| trackingEle.SetText(eventURLMap[event]) |
There was a problem hiding this comment.
I think this needs to be CData instead of plain text.
Pubmatic-Dhruv-Sonone
requested changes
Sep 1, 2023
| eventURL = replaceMacro(eventURL, PBSAccountMacro, req.Site.Publisher.ID) | ||
| } | ||
|
|
||
| if req != nil { |
There was a problem hiding this comment.
Is this check even required at this stage?
| err := json.Unmarshal(req.Ext, &reqExt) | ||
| if err == nil { | ||
| customMacroMap = reqExt.Prebid.Macros | ||
| // replace standard macros |
There was a problem hiding this comment.
Request Level macro remain constant for all the tracker. Can we populate this only once?
Comment on lines
+198
to
+203
| // lookup in custom macros - keep this block at last for highest priority | ||
| reqExt := new(openrtb_ext.ExtRequest) | ||
| if req.Ext != nil { | ||
| err := json.Unmarshal(req.Ext, &reqExt) | ||
| if err != nil { | ||
| glog.Warningf("Error in unmarshling req.Ext.Prebid.Vast: [%s]", err.Error()) |
There was a problem hiding this comment.
Can we get access to requestWrapper here, will reduce the extract unmarshling overhead?
ShriprasadM
requested changes
Sep 1, 2023
exchange/auction.go
Outdated
| `<VASTAdTagURI><![CDATA[%v]]></VASTAdTagURI>` + | ||
| `<Impression></Impression><Creatives></Creatives>` + | ||
| `</Wrapper></Ad></VAST>` | ||
| wrapperVASTTemplate := `<VAST version="3.0"><Ad><Wrapper><AdSystem>prebid.org wrapper</AdSystem><VASTAdTagURI><![CDATA[%v]]></VASTAdTagURI><Impression></Impression><Creatives></Creatives></Wrapper></Ad></VAST>` |
There was a problem hiding this comment.
Let us revert formatting change. This is prebid function
pm-nilesh-chate
dismissed
pm-viral-vala’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add change description or link to ticket, docs, etc.
Checklist:
header-biddingrepo with appropiate commit id.For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade