Skip to content

Changes for Go version upgrade 1.24 #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: ci
Choose a base branch
from
Open

Changes for Go version upgrade 1.24 #1123

wants to merge 2 commits into from

Conversation

pm-aditi-bansal
Copy link
Collaborator

Description

Please add change description or link to ticket, docs, etc.

Checklist:

  • PR commit list is unique (rebase/pull with the origin branch to keep master clean).
  • JIRA number is added in the PR title and the commit message.
  • Updated the header-bidding repo with appropiate commit id.
  • Documented the new changes.

For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4b353fe

adapterstest

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/adapter_test_util.go:23:	BidOnTags			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/adapter_test_util.go:33:	SampleBid			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/adapter_test_util.go:46:	VerifyStringValue		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/adapter_test_util.go:53:	VerifyIntValue			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/adapter_test_util.go:60:	VerifyBoolValue			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/adapter_test_util.go:67:	VerifyBannerSize		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:70:		RunJSONBidderTest		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:83:		RunSingleJSONBidderTest		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:105:		loadFile			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:127:		runSpec				0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:135:		getTestExtraRequestInfo		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:185:		expectsErrors			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:194:		ToRequestData			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:215:		ToResponseData			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:244:		assertMakeRequestsOutput	0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:262:		assertErrorList			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:287:		assertMakeBidsOutput		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:307:		diffHttpRequests		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:342:		diffBids			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:357:		diffOrtbBids			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:370:		diffBidVideo			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:381:		diffJson			0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:419:		testMakeRequestsImpl		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:440:		getDataRaceTestCopies		0.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/adapterstest/test_json.go:461:		testMakeBidsImpl		0.0%
total:												(statements)			0.0%

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:19:	parseRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:46:	makeRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:39:		InitBidderParamsConfig	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:45:		Builder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:64:		MakeRequests		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:83:		MakeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:98:		makeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:50:	getEndpoint		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:62:	cloneRequest		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:72:	appendRequestData	80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:23:	newResponseBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:37:	setPrebidBidderResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:100:	buildAdapterResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:116:	collectWarningMessages	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:21:	parseRequest		77.8%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:53:	makeRequest		91.7%
total:												(statements)		92.2%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant