UOE-12550: Adding placementid support for Nativo #1105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
nativoRefer here for heat map coverage report |
Code coverage summaryNote:
nativoRefer here for heat map coverage report |
Pubmatic-Supriya-Patil
previously approved these changes
Jun 19, 2025
|
|
||
| for i := range request.Imp { | ||
|
|
||
| imp := &request.Imp[i] |
There was a problem hiding this comment.
We don't need additional variable declaration, if we access by index then it will be pass by reference
There was a problem hiding this comment.
Accessing the request.imp directly and later updating the imp.ext changes the original incoming request.
| @@ -807,3 +807,14 @@ func builderOpenweb(params BidderParameters) (json.RawMessage, error) { | |||
| jsonStr.WriteByte('}') | |||
| return jsonStr.Bytes(), nil | |||
| } | |||
|
|
|||
| func builderNativo(params BidderParameters) (json.RawMessage, error) { | |||
There was a problem hiding this comment.
Can be rewritten as
func builderNativo(params BidderParameters) (json.RawMessage, error) {
if pid, ok := getInt(params.FieldMap["placementId"]); !ok || pid == 0 {
return nil, fmt.Errorf(errMandatoryParameterMissingFormat, params.AdapterName, "placementId")
}
jsonStr := bytes.Buffer{}
fmt.Fprintf(&jsonStr, `{"placementid":"%d"}`, pid)
return jsonStr.Bytes(), nil
}| @@ -807,3 +807,14 @@ func builderOpenweb(params BidderParameters) (json.RawMessage, error) { | |||
| jsonStr.WriteByte('}') | |||
| return jsonStr.Bytes(), nil | |||
| } | |||
|
|
|||
| func builderNativo(params BidderParameters) (json.RawMessage, error) { | |||
| jsonStr := bytes.Buffer{} | |||
There was a problem hiding this comment.
Nitpick: We can use bytes.NewBuffer() to create a new buffer
Code coverage summaryNote:
nativoRefer here for heat map coverage report |
|
Closing as PR is raised via Pubmatic-openwrap account |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add change description or link to ticket, docs, etc.
Checklist:
header-biddingrepo with appropiate commit id.For Prebid upgrade, refer: https://inside.pubmatic.com:8443/confluence/display/Products/Prebid-server+upgrade