Skip to content

UOE-12397: Add advertiser domain and category tags to VAST XML in strict vast mode #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 10, 2025

Conversation

Pubmatic-Supriya-Patil
Copy link
Collaborator

No description provided.

ShriprasadM
ShriprasadM previously approved these changes Jun 9, 2025
Copy link
Collaborator

@ShriprasadM ShriprasadM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pubmatic-Supriya-Patil : PR looks good now with some minor comments. See if you can address them in current story based on timelines.
Approving PR

ShriprasadM
ShriprasadM previously approved these changes Jun 10, 2025
Copy link
Collaborator

@ShriprasadM ShriprasadM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@pm-jaydeep-mohite pm-jaydeep-mohite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pm-jaydeep-mohite pm-jaydeep-mohite merged commit 84d3827 into ci Jun 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants