UOE-11577: Fixed vast rejection logger issue for ctv if multiple partner to profile #1085

pm-priyanka-bagade · 2025-05-28T10:09:08Z

No description provided.

github-actions · 2025-05-28T10:09:56Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4e34bce

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:19:	parseRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:46:	makeRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:39:		InitBidderParamsConfig	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:45:		Builder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:64:		MakeRequests		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:83:		MakeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:98:		makeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:50:	getEndpoint		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:62:	cloneRequest		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:72:	appendRequestData	80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:23:	newResponseBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:37:	setPrebidBidderResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:100:	buildAdapterResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:116:	collectWarningMessages	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:21:	parseRequest		77.8%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:53:	makeRequest		91.7%
total:												(statements)		92.2%

modules/pubmatic/openwrap/hook_raw_bidder_response_test.go

github-actions · 2025-06-05T10:16:12Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 07402a5

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:19:	parseRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:46:	makeRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:39:		InitBidderParamsConfig	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:45:		Builder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:64:		MakeRequests		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:83:		MakeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:98:		makeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:50:	getEndpoint		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:62:	cloneRequest		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:72:	appendRequestData	80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:23:	newResponseBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:37:	setPrebidBidderResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:100:	buildAdapterResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:116:	collectWarningMessages	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:21:	parseRequest		77.8%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:53:	makeRequest		91.7%
total:												(statements)		92.2%

ShriprasadM

@pm-priyanka-bagade : checkout review comments. Also plan to contribute this in vanilla prebid-server.

ShriprasadM · 2025-06-06T12:36:17Z

exchange/bidder.go

@@ -272,6 +272,7 @@ func (bidder *BidderAdapter) requestBid(ctx context.Context, bidderRequest Bidde
 			if bidResponse != nil {
 				recordOpenWrapBidResponseMetrics(bidder, bidResponse)

+				bidResponse.BidderName = bidderRequest.BidderName


@pm-priyanka-bagade : Rename bidResponse.BidderName to bidResponse.BidderAlias for clear readability

github-actions · 2025-06-11T07:01:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, c8cfee9

ortbbidder

Refer here for heat map coverage report

github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:19:	parseRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/multi_request_builder.go:46:	makeRequest		75.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:39:		InitBidderParamsConfig	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:45:		Builder			100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:64:		MakeRequests		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:83:		MakeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/ortbbidder.go:98:		makeBids		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:32:	newRequestBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:50:	getEndpoint		100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:62:	cloneRequest		80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/request_builder.go:72:	appendRequestData	80.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:12:	setRequestParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:32:	addIndicesInPath	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/requestparam_mapper.go:48:	getImpExtBidderParams	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:23:	newResponseBuilder	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:37:	setPrebidBidderResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:100:	buildAdapterResponse	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/response_builder.go:116:	collectWarningMessages	100.0%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:21:	parseRequest		77.8%
github.com/PubMatic-OpenWrap/prebid-server/v3/adapters/ortbbidder/single_request_builder.go:53:	makeRequest		91.7%
total:												(statements)		92.2%

pm-priyanka-bagade · 2025-06-24T10:16:01Z

created different branch UOE-11577-ci from latest ci

UOE-11577: Fixed vast reject in ctv for logger

4e34bce

pm-priyanka-bagade changed the title ~~UOE-11577: Fixed vast reject in llogger issue for ctv if multiple partner to profile~~ UOE-11577: Fixed vast rejection logger issue for ctv if multiple partner to profile May 28, 2025

pm-jaydeep-mohite reviewed May 29, 2025

View reviewed changes

modules/pubmatic/openwrap/hook_raw_bidder_response_test.go Outdated Show resolved Hide resolved

pm-priyanka-bagade added 2 commits June 5, 2025 15:29

Merge branch 'ci' into UOE-11577

a42d83f

UOE-11577:resolved comments

07402a5

pm-jaydeep-mohite requested a review from ShriprasadM June 6, 2025 05:57

ShriprasadM requested changes Jun 6, 2025

View reviewed changes

pm-priyanka-bagade added 2 commits June 11, 2025 12:06

Merge branch 'ci' into UOE-11577

490fac7

UOE-11577: Resolve comments

c8cfee9

pm-priyanka-bagade closed this Jun 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UOE-11577: Fixed vast rejection logger issue for ctv if multiple partner to profile #1085

UOE-11577: Fixed vast rejection logger issue for ctv if multiple partner to profile #1085

Uh oh!

pm-priyanka-bagade commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025

Uh oh!

ShriprasadM left a comment

Uh oh!

ShriprasadM Jun 6, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

pm-priyanka-bagade commented Jun 24, 2025

Uh oh!

Uh oh!

UOE-11577: Fixed vast rejection logger issue for ctv if multiple partner to profile #1085

UOE-11577: Fixed vast rejection logger issue for ctv if multiple partner to profile #1085

Uh oh!

Conversation

pm-priyanka-bagade commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025

Code coverage summary

ortbbidder

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025

Code coverage summary

ortbbidder

Uh oh!

ShriprasadM left a comment

Choose a reason for hiding this comment

Uh oh!

ShriprasadM Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 11, 2025

Code coverage summary

ortbbidder

Uh oh!

pm-priyanka-bagade commented Jun 24, 2025

Uh oh!

Uh oh!