-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Classifier free guidance #8460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ericspod
merged 12 commits into
Project-MONAI:dev
from
virginiafdez:classifier-free-guidance
May 27, 2025
Merged
Classifier free guidance #8460
ericspod
merged 12 commits into
Project-MONAI:dev
from
virginiafdez:classifier-free-guidance
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Virginia Fernandez <[email protected]>
Signed-off-by: Virginia Fernandez <[email protected]>
….ac.uk>\nI, Virginia Fernandez <[email protected]>, hereby add my Signed-off-by to this commit: 79f357a\nSigned-off-by: Virginia Fernandez <[email protected]> Signed-off-by: Virginia Fernandez <[email protected]>
Signed-off-by: Virginia Fernandez <[email protected]>
Signed-off-by: Virginia Fernandez <[email protected]>
….ac.uk> I, Virginia Fernandez <[email protected]>, hereby add my Signed-off-by to this commit: 79f357a Signed-off-by: Virginia Fernandez <[email protected]>
Signed-off-by: Virginia Fernandez <[email protected]>
ericspod
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8448
Description
Classifier-free guidance scale can be used in the sampling methods of diffusion models to strengthen the conditioning. It's been used in one of the generative MONAI tutorials, but the actual Inferers (DiffusionInferer, and ControlNetDiffusionInferer) do not support this feature. This means that, whenever users want to use CFG, they have to either copy the Inferer object or write their own sampling method.
This PR incorporates classifier-free guidance into the inferer objects by modifying their sampling method and adding an argument cfg to the sampling method to control this.
This should not change the default behaviour (cfg=None), although some rewriting has been necessary.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.