Skip to content

Fix Ruff Numpy2 deprecation rules #8179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jamesobutler
Copy link
Contributor

Description

This addresses expired numpy deprecations that happened with the numpy 2 release. This code is compatible with numpy 1 and 2 to support future enablement of numpy2 for monai.

See https://docs.astral.sh/ruff/rules/numpy2-deprecation/

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@ericspod ericspod requested a review from KumoLiu October 24, 2024 18:36
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this all looks fine to me.

@KumoLiu
Copy link
Contributor

KumoLiu commented Oct 25, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) October 25, 2024 01:50
@KumoLiu KumoLiu merged commit 5b2d78e into Project-MONAI:dev Oct 25, 2024
28 checks passed
@jamesobutler jamesobutler deleted the jamesobutler-ruff-numpy-updates branch October 25, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants