-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Make RandTorchVisiond and RandCuCIMd Consistent #5569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachidanandAlle
previously approved these changes
Nov 23, 2022
d3fa0aa
to
f343cee
Compare
f343cee
to
68b78d2
Compare
Signed-off-by: Behrooz <[email protected]>
wyli
reviewed
Nov 23, 2022
I agree on that naming part.. let it consistent across all other transforms unless prob field is already taken by some torch vision function (as we r passing kwargs) |
Logically looks ok to me.. I will let others to decide on standard convention and approve
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
wyli
approved these changes
Dec 5, 2022
/build |
wyli
reviewed
Dec 5, 2022
Co-authored-by: Wenqi Li <[email protected]>
/black |
Signed-off-by: Behrooz <[email protected]>
…update-rand-wrappers
Signed-off-by: monai-bot <[email protected]>
/build |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both RandTorchVisiond and RandCuCIMd are dealing with the third-party libraries and they should have the same API, especially on using
apply_prob
instead ofprob
since it is different than theprob
of the underlying randomized tranform.Types of changes