Skip to content

Make RandTorchVisiond and RandCuCIMd Consistent #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 7, 2022

Conversation

bhashemian
Copy link
Member

Description

Both RandTorchVisiond and RandCuCIMd are dealing with the third-party libraries and they should have the same API, especially on using apply_prob instead of prob since it is different than the prob of the underlying randomized tranform.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@bhashemian bhashemian reopened this Nov 23, 2022
@SachidanandAlle
Copy link
Contributor

I agree on that naming part.. let it consistent across all other transforms unless prob field is already taken by some torch vision function (as we r passing kwargs)

@SachidanandAlle SachidanandAlle dismissed their stale review November 28, 2022 03:18

Logically looks ok to me.. I will let others to decide on standard convention and approve

@wyli
Copy link
Contributor

wyli commented Dec 5, 2022

/build

@wyli wyli enabled auto-merge (squash) December 5, 2022 22:06
@wyli
Copy link
Contributor

wyli commented Dec 7, 2022

/black

@wyli wyli disabled auto-merge December 7, 2022 16:18
@wyli
Copy link
Contributor

wyli commented Dec 7, 2022

/build

@wyli wyli merged commit 3873d23 into Project-MONAI:dev Dec 7, 2022
@bhashemian bhashemian deleted the update-rand-wrappers branch December 7, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants