-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Unified Focal Loss #4488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unified Focal Loss #4488
Conversation
thanks, please sign the commit https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work there are also some minor typing issues https://github.com/Project-MONAI/MONAI/runs/6858724085?check_suite_focus=true#step:7:532 |
Signed-off-by: JohnMasoner <[email protected]>
Signed-off-by: JohnMasoner <[email protected]>
Hi @danieltudosiu, could you help review this one if you have some time? thanks! |
@wyli will have a look over the weekend. |
@wyli Thank you for reviewing the code. I'm thinking about whether to add multiple categories or just support binary segmentation only. |
thanks, I think the initial support of the binary cases is good (as long as we have the docstring and input check), we can create a new feature request/PR for multiclass extension |
Signed-off-by: JohnMasoner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I only have a few minor comments about the documentation, otherwise we can merge these new modules.
Signed-off-by: JohnMasoner <[email protected]>
@wyli thanks, you took the time to review my code. this has been a great help to me. |
/build |
1 similar comment
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, the tests look good, please help fix the typos then I'll merge this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/build |
Fixes #4413
Description
Add Unified Focal Loss, about the issue
Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.