Skip to content

Visual Brace Matching - handle < > #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProgerXP opened this issue Mar 2, 2020 · 5 comments
Closed

Visual Brace Matching - handle < > #283

ProgerXP opened this issue Mar 2, 2020 · 5 comments
Assignees

Comments

@ProgerXP
Copy link
Owner

ProgerXP commented Mar 2, 2020

It looks like < > were artificially excluded from Visual Brace Matching because it's the only pair of Unwrap Brackets that isn't highlighted.

@cshnik
Copy link
Collaborator

cshnik commented Mar 3, 2020

Fixed.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Mar 3, 2020
@ProgerXP
Copy link
Owner Author

ProgerXP commented Mar 3, 2020

With other types of brackets, positioning caret after the closing bracket does highlighting. However, for > this doesn't happen. Compare:

()|
<>|

1
2

@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Mar 3, 2020
cshnik added a commit that referenced this issue Mar 5, 2020
@cshnik
Copy link
Collaborator

cshnik commented Mar 5, 2020

Fixed.
But strange thing here is that original Notepad2 code use all types of brackets, while initial commit in this repository has missing <>:

if (StrChrA("()[]{}",c))
   iBrace2 = (int)SendMessage(hwndEdit,SCI_BRACEMATCH,iPos,0);

@cshnik cshnik assigned ProgerXP and unassigned cshnik Mar 5, 2020
@ProgerXP
Copy link
Owner Author

ProgerXP commented Mar 6, 2020

But strange thing here is that original Notepad2 code use all types of brackets, while initial commit in this repository has missing <>

I compared our initial sources with Notepad2's after removing whitespace and brackets. There are no differences between 17e2a9d (except for several new lines were which later moved to "Extension") and Notepad2 4.2.25 (http://www.flos-freeware.ch/zip/notepad2_4.2.25_src.zip). You are mistaken - Notepad2 doesn't handle <> (http://www.flos-freeware.ch/zip/Notepad2_4.2.25_x86.exe).

@ProgerXP ProgerXP assigned cshnik and unassigned ProgerXP Mar 15, 2020
@cshnik
Copy link
Collaborator

cshnik commented Mar 17, 2020

You are mistaken - Notepad2 doesn't handle <>

You are right.

Do we need any other changes to address this issue?

@cshnik cshnik assigned ProgerXP and unassigned cshnik Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants