Skip to content

Find button states not updated on switch to Transform backslashes #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ProgerXP opened this issue Apr 8, 2019 · 3 comments
Closed

Find button states not updated on switch to Transform backslashes #219

ProgerXP opened this issue Apr 8, 2019 · 3 comments

Comments

@ProgerXP
Copy link
Owner

ProgerXP commented Apr 8, 2019

  1. Open Find
  2. Enter } into the search string
  3. Enable regexps - buttons will be disabled because it's not a valid expression
  4. Now enable Transform backslashes - the expression is now valid but buttons are still disabled
@cshnik
Copy link
Collaborator

cshnik commented Jul 3, 2019

Fixed.
Step 2 should be read as "Enter \ into the search string".

@cshnik cshnik assigned ProgerXP and unassigned cshnik Jul 3, 2019
@ProgerXP ProgerXP closed this as completed Jul 5, 2019
@ProgerXP
Copy link
Owner Author

ProgerXP commented Jul 6, 2019

Related bug so posting here.

Buttons are not updated when the input's value changes using the combobox. For example, enable regexp mode, enter [ into the search input then switch to another value from the history (which is a valid regexp) with the arrow button and mouse - now Search String is valid but buttons are disabled anyway.

@cshnik
Copy link
Collaborator

cshnik commented Jul 15, 2019

Buttons are not updated when the input's value changes using the combobox.

Fixed.

@cshnik cshnik assigned ProgerXP and unassigned cshnik Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants