Skip to content

Introduce MessageBuilder #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 13, 2021
Merged

Introduce MessageBuilder #23

merged 7 commits into from
Jul 13, 2021

Conversation

u9g
Copy link
Member

@u9g u9g commented Jun 29, 2021

Adds new MessageBuilder export that allows easy creation of ChatMessage's, for use in FlyingSquid or /tellraw ingame

@u9g
Copy link
Member Author

u9g commented Jun 29, 2021

Needs PrismarineJS/prismarine-nbt#44 to be merged

@u9g u9g changed the title Complete refactor of #12 that isn't breaking Introduce MessageBuilder Jun 29, 2021
@u9g
Copy link
Member Author

u9g commented Jul 3, 2021

should use PrismarineJS/prismarine-nbt#48

@rom1504
Copy link
Member

rom1504 commented Jul 6, 2021

PrismarineJS/prismarine-nbt#48 landed, want to finish this ?

@u9g
Copy link
Member Author

u9g commented Jul 7, 2021

PrismarineJS/prismarine-nbt#48 landed, want to finish this ?

done

Copy link
Member

@rom1504 rom1504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you add MessageBuilder to the readme ?

@builder-247
Copy link
Contributor

Could you add a function to convert from motd to chatmessage or shall I open a PR once this has landed?

@u9g
Copy link
Member Author

u9g commented Jul 13, 2021

looks good, can you add MessageBuilder to the readme ?

Added

Could you add a function to convert from motd to chatmessage or shall I open a PR once this has landed?

Done

@rom1504 rom1504 merged commit 29f042a into PrismarineJS:master Jul 13, 2021
@u9g u9g deleted the mybranch branch July 13, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants