Skip to content

1.21.5 Java edition support #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Seanspt opened this issue Apr 27, 2025 · 15 comments
Open

1.21.5 Java edition support #3641

Seanspt opened this issue Apr 27, 2025 · 15 comments
Labels
new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f

Comments

@Seanspt
Copy link

Seanspt commented Apr 27, 2025

Any one working on it?
@Seanspt Seanspt added new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Apr 27, 2025
@rom1504
Copy link
Member

rom1504 commented Apr 27, 2025

blocked on PrismarineJS/node-minecraft-protocol#1386

I think nobody is working on it. Help welcome

@rom1504 rom1504 pinned this issue Apr 27, 2025
@rom1504
Copy link
Member

rom1504 commented Apr 27, 2025

@RomainNeup would you like to finish this?

This was referenced Apr 27, 2025
Draft
Open
@rom1504
Copy link
Member

rom1504 commented Apr 27, 2025

Funding this for $200 since this version has been pending for a few months at this point. Will be shared between contributors and paid thanks to https://opencollective.com/dashboard/prismarinejs

@Seanspt
Copy link
Author

Seanspt commented Apr 27, 2025

I searched 'checksum' in minecraft-data. It seems suspicious to me that there is no checksum definition in proto.yml as in bedrock ones. And it's in data/pc/common/features.json, does common mean it works for all the versions?

Image

@Seanspt
Copy link
Author

Seanspt commented Apr 27, 2025

FYI 1.21.5 change log

@rom1504
Copy link
Member

rom1504 commented Apr 27, 2025

PrismarineJS/minecraft-data#995

@Seanspt
Copy link
Author

Seanspt commented Apr 27, 2025

PrismarineJS/minecraft-data#995

I don't think the proto.yml is right. I found a proto wiki here. But there is no download link for a raw proto file. How is the proto.yml generated? Is it manually maintained?

@rom1504
Copy link
Member

rom1504 commented Apr 27, 2025

Yes it's manually maintained and it's usually more correct than the wiki.
The reference is Minecraft source code

If you see any specific error feel free to point them out in the Minecraft data PR

@Seanspt
Copy link
Author

Seanspt commented Apr 27, 2025

FYI minecraft source code

@Seanspt
Copy link
Author

Seanspt commented Apr 28, 2025

The proto.yml didn't apply the changes. I'm fixing it and stuck at packet_map_chunk. Help needed. Here is the yml I'm using.

proto.yml.txt

@rom1504
Copy link
Member

rom1504 commented Apr 28, 2025 via email

@Seanspt
Copy link
Author

Seanspt commented Apr 29, 2025

I created a pr. Still debugging.

@Seanspt
Copy link
Author

Seanspt commented Apr 30, 2025

The map chunk load failure might be related to this. Need to fix it in prismarine-chunk

Image

@rom1504
Copy link
Member

rom1504 commented May 18, 2025

linking 1.21.5 stuff in PrismarineJS/minecraft-data#994

@hhjjj75
Copy link

hhjjj75 commented May 22, 2025

Could ViaFabricPlus be ported to mineflayer https://modrinth.com/mod/viafabricplus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rom1504 @Seanspt @hhjjj75