Add tag filtering support for automations #18288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguidry
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
This implements the next part of #16771 by adding comprehensive tag filtering capabilities for automations, following the same pattern used by other entities in Prefect (flows, deployments, etc.). Changes: - Add tags field to Automation database model with JSON column and migrations - Update automation schemas (client and server) to include tags field - Implement AutomationFilterTags with all_, any_, and is_null_ filter options - Add comprehensive test coverage for all filtering scenarios - Ensure API compatibility with existing automation functionality The filtering supports: - all_: Return automations that have ALL specified tags (superset match) - any_: Return automations that have ANY of the specified tags - is_null_: Return automations with no tags (true) or with tags (false) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove duplicate migration files that conflicted with existing migrations - Fix duplicate tags field definition in client automation schema - Existing migrations aa1234567890 (PostgreSQL) and bb2345678901 (SQLite) already handle tags column 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
chrisguidry
force-pushed
the
add-automation-tag-filtering
branch
from
adaf06b to
a28a07d
Compare
CodSpeed Performance ReportMerging #18288 will not alter performanceComparing Summary
|
zzstoatzz
approved these changes
Jun 16, 2025
| @@ -416,7 +416,7 @@ class AutomationCore(PrefectBaseModel, extra="ignore"): # type: ignore[call-arg | |||
| enabled: bool = Field( | |||
| default=True, description="Whether this automation will be evaluated" | |||
| ) | |||
| tags: list[str] = Field( | |||
| tags: List[str] = Field( | |||
There was a problem hiding this comment.
Suggested change
| tags: List[str] = Field( | |
| tags: list[str] = Field( |
There was a problem hiding this comment.
Ahh, the rest of that model is using the typing module types, I'll just change them all
There was a problem hiding this comment.
ohh my bad. I didn't notice that, either way 🙇
There was a problem hiding this comment.
I'll send a followup PR, actually, just to do them all together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements the next part of #16771 by adding comprehensive tag filtering capabilities for automations, following the same pattern used by other entities in Prefect (flows, deployments, etc.).
Changes
tagsfield to Automation database model with JSON column and migrationstagsfieldAutomationFilterTagswithall_,any_, andis_null_filter optionsFiltering Options
The filtering supports:
all_: Return automations that have ALL specified tags (superset match)any_: Return automations that have ANY of the specified tagsis_null_: Return automations with no tags (true) or with tags (false)Closes #16771
🤖 Generated with Claude Code