Skip to content

fix: few performance improvements #18136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

fatih-acar
Copy link
Contributor

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Performance Report

Merging #18136 will not alter performance

Comparing fatih-acar:fac-perf-improvements (1e1c7fd) with main (0107f74)

Summary

✅ 2 untouched benchmarks

@fatih-acar fatih-acar force-pushed the fac-perf-improvements branch from b605241 to fcff65f Compare May 21, 2025 19:25
@zzstoatzz
Copy link
Collaborator

superseded, see: #18150

@zzstoatzz zzstoatzz closed this Jun 4, 2025
@fatih-acar
Copy link
Contributor Author

Hi @zzstoatzz I think you meant to close this PR instead: #18135

For this one, the changes are still valable but I just don't have time to run benchmarks for this, yet...

@zzstoatzz
Copy link
Collaborator

oof you are totally right - thank you!

@zzstoatzz zzstoatzz reopened this Jun 4, 2025
@zzstoatzz
Copy link
Collaborator

superseded by #18314 (for real this time 😅 )

@zzstoatzz zzstoatzz closed this Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants