-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Replaced deprecated logic in SPCS worker #18105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced deprecated logic in SPCS worker #18105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @bjorhn it looks like we need to update a test here, otherwise this LGTM
@zzstoatzz I'm not sure how any of my changes relate to that test, am I missing something? Is it possible that my snowflake dependency bump is forcing a higher version of snowflake-connector, which, in turn, causes the test to fail? |
@bjorhn yea i would guess the new versions just handle that PEM loading error a bit different so i suspect we'd just need to update the expected error message we're matching on now if you get stuck on that I can take a look later |
@zzstoatzz I had a quick look at this but at the moment I don't know when I can sit down and get this fixed. PEM loading isn't really my area of expertise. If you are able to take a look at this, please do, otherwise I will probably return to it at a later date. |
ok @bjorhn I will take a look at this later this week |
53b14d0
to
fca0367
Compare
fca0367
to
6c87175
Compare
6c87175
to
36dc780
Compare
the diff is massive here because of: astral-sh/uv#13176 its all just changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @bjorhn - apologies for the delay here
This PR updates the Snowpark Container Services worker to handle recent changes in the API of the Snowflake Python SDK:
There are no new unit tests since there is no new functionality.
This code is running in production at my workplace with no issues.
Closes #18104
Checklist
<link to issue>
"mint.json
.