Skip to content
This repository was archived by the owner on Feb 24, 2021. It is now read-only.

Deprecate xSmbShare #499

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Deprecate xSmbShare #499

merged 2 commits into from
Jul 4, 2019

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Apr 13, 2019 •
edited
Loading

Pull Request (PR) description

Deprecating this resource module xSmbShare.

This PR should only be merged once the PR dsccommunity/ComputerManagementDsc#211, and the PR dsccommunity/xSmbShare#31 is merged.

This Pull Request (PR) fixes the following issues

As discussed in issue #374.

Task list

  • This PR changes documentation

This change is Reviewable

@gaelcolas
Copy link
Contributor

Can you also make sure there's a PR on xSmbShare that updates the changelog and probably write a Warning message when imported.
Please reference it here so it's easier to track.

@johlju
Copy link
Contributor Author

johlju commented Apr 19, 2019

There are already a pending PR dsccommunity/xSmbShare#31 taking care of that. Although should we write a warning message in xSmbShare? We haven’t done that for any other deprecated module, and the resource do work for those that are using it. Do we want them to get a warning message each time the module is imported? But if we want that, how do I output a warning message the best way when a module is imported? 😄

@gaelcolas gaelcolas self-assigned this Apr 23, 2019
@gaelcolas
Copy link
Contributor

Nah, no need. I thought I saw that done before :/ nvm!

Will merge after next Resource Kit release.

@johlju
Copy link
Contributor Author

johlju commented Apr 29, 2019

Waiting for the PR to be reviewed in ComputerManagementDsc. Hen that is merged I will take this one out of draft.

@gaelcolas gaelcolas added on hold The issue or pull request has been put on hold by a maintainer. in progress The issue is being actively worked on by someone. and removed in progress The issue is being actively worked on by someone. labels Jun 25, 2019
@PlagueHO
Copy link
Contributor

PlagueHO commented Jul 4, 2019

@johlju - should be good to go with this one! 😁

@johlju johlju marked this pull request as ready for review July 4, 2019 07:51
@johlju johlju force-pushed the deprecate-xSmbShare branch from a1e3fbb to 2e56ad4 Compare July 4, 2019 07:55
@johlju
Copy link
Contributor Author

johlju commented Jul 4, 2019

@gaelcolas ready for review.

@gaelcolas gaelcolas merged commit 5f4c587 into PowerShell:master Jul 4, 2019
@gaelcolas gaelcolas removed the on hold The issue or pull request has been put on hold by a maintainer. label Jul 4, 2019
@johlju johlju deleted the deprecate-xSmbShare branch August 2, 2019 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaelcolas gaelcolas gaelcolas approved these changes

Assignees

@gaelcolas gaelcolas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johlju @gaelcolas @PlagueHO