Skip to content
This repository was archived by the owner on Feb 24, 2021. It is now read-only.

Created a helper script to build comment help based comments #341

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

kungfoome
Copy link

@kungfoome kungfoome commented Jul 22, 2019

This is still not quite complete. Need to add some tests and clean some code up, but it's a start

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jul 22, 2019

Codecov Report

Merging #341 into dev will decrease coverage by 6%.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #341    +/-   ##
====================================
- Coverage    79%    73%    -7%     
====================================
  Files        12     14     +2     
  Lines      1776   1921   +145     
  Branches      2      2            
====================================
  Hits       1420   1420            
- Misses      354    499   +145     
  Partials      2      2

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Aug 6, 2019
@PlagueHO
Copy link
Contributor

PlagueHO commented Aug 6, 2019

Awesome stuff @kungfu71186 - sorry I missed this! Will review this week.

@PlagueHO PlagueHO self-requested a review September 9, 2019 06:00
@johlju
Copy link
Contributor

johlju commented Feb 28, 2020

@kungfu71186 We should move this to the module DscResource.DocGenerator and create a build task for it (see other task in that module).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants