Skip to content

feat: Fix comment #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

feat: Fix comment #2078

merged 1 commit into from
Jul 8, 2025

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Jul 8, 2025

Changes

This comment said that it masked utm tags, but this is not true.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)
  • Took care not to unnecessarily increase the bundle size

Copy link

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jul 8, 2025 11:27am

@robbie-c robbie-c requested review from rafaeelaudibert, a team, lricoy and jabahamondes and removed request for a team July 8, 2025 11:12
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Documentation fix to correct an inaccurate comment about property masking in packages/browser/src/types.ts. The change clarifies that mask_personal_data_properties masks advertising IDs (gclid, fbclid) rather than UTM parameters.

  • Updated configuration documentation in types.ts to accurately describe the masking behavior for advertising IDs
  • Added helpful examples to improve clarity of the masking functionality
  • Fixed misleading comment that incorrectly claimed UTM parameter masking

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link

github-actions bot commented Jul 8, 2025

Copy link

github-actions bot commented Jul 8, 2025

Size Change: 0 B

Total Size: 3.59 MB

ℹ️ View Unchanged
Filename Size
packages/browser/dist/all-external-dependencies.js 220 kB
packages/browser/dist/array.full.es5.js 308 kB
packages/browser/dist/array.full.js 372 kB
packages/browser/dist/array.full.no-external.js 390 kB
packages/browser/dist/array.js 172 kB
packages/browser/dist/array.no-external.js 187 kB
packages/browser/dist/crisp-chat-integration.js 1.97 kB
packages/browser/dist/customizations.full.js 15.9 kB
packages/browser/dist/dead-clicks-autocapture.js 12.6 kB
packages/browser/dist/exception-autocapture.js 9.55 kB
packages/browser/dist/external-scripts-loader.js 2.57 kB
packages/browser/dist/intercom-integration.js 2.02 kB
packages/browser/dist/main.js 173 kB
packages/browser/dist/module.full.js 373 kB
packages/browser/dist/module.full.no-external.js 390 kB
packages/browser/dist/module.js 173 kB
packages/browser/dist/module.no-external.js 188 kB
packages/browser/dist/posthog-recorder.js 207 kB
packages/browser/dist/recorder-v2.js 113 kB
packages/browser/dist/recorder.js 113 kB
packages/browser/dist/surveys-preview.js 70.8 kB
packages/browser/dist/surveys.js 79 kB
packages/browser/dist/tracing-headers.js 1.63 kB
packages/browser/dist/web-vitals.js 10.4 kB

compressed-size-action

@robbie-c robbie-c merged commit dd6fca5 into main Jul 8, 2025
40 of 41 checks passed
@robbie-c robbie-c deleted the fix-comment branch July 8, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants