-
Notifications
You must be signed in to change notification settings - Fork 159
fix: fix release workflow #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7e0b983
to
3446d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Fixes the continuous deployment workflow by adjusting package version checking and test configurations.
- Added correct 'path' parameter to
check-package-version
action in.github/workflows/cd.yml
to properly targetpackages/browser
directory - Removed custom ESLint rules tests from main test script in
packages/browser/package.json
to streamline release process - Custom ESLint rules testing is now decoupled from the main test suite, allowing releases to proceed without this validation step
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
daibhin
approved these changes
Jun 16, 2025
daibhin
added a commit
that referenced
this pull request
Jun 16, 2025
daibhin
added a commit
that referenced
this pull request
Jun 16, 2025
Size Change: 0 B Total Size: 3.55 MB ℹ️ View Unchanged
|
daibhin
added a commit
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes