Skip to content

fix: detect and mask SwiftUI Text vs Image #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix: detect and mask SwiftUI Text vs Image #257

merged 3 commits into from
Nov 19, 2024

Conversation

ioannisj
Copy link
Contributor

@ioannisj ioannisj commented Nov 19, 2024 •
edited
Loading

💡 Motivation and Context

Closes #163

Small refactor to distinguish between SwiftUI Image and Text

docs: PostHog/posthog.com#9921

config.sessionReplayConfig.maskAllTextInputs = true
config.sessionReplayConfig.maskAllImages = false

CleanShot 2024-11-19 at 14 54 29@2x

config.sessionReplayConfig.maskAllTextInputs = false
config.sessionReplayConfig.maskAllImages = true

CleanShot 2024-11-19 at 14 52 13@2x

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@ioannisj ioannisj marked this pull request as draft November 19, 2024 13:49
@ioannisj ioannisj requested a review from a team November 19, 2024 13:50
marandaneto
marandaneto reviewed Nov 19, 2024
View reviewed changes
PostHogExample/Assets.xcassets/max_static.imageset/Contents.json
{
"images" : [
{
"filename" : "max_static.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@marandaneto
Copy link
Member

once this is merged/released, we can remove the mentions of this issue #163 on the docs https://github.com/search?q=repo%3APostHog%2Fposthog.com+https%3A%2F%2Fgithub.com%2FPostHog%2Fposthog-ios%2Fissues%2F163&type=code

@ioannisj
Copy link
Contributor Author

once this is merged/released, we can remove the mentions of this issue #163 on the docs github.com/search?q=repo%3APostHog%2Fposthog.com+https%3A%2F%2Fgithub.com%2FPostHog%2Fposthog-ios%2Fissues%2F163&type=code

Thanx, was actually looking for that!

marandaneto
marandaneto approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY NICE BUG FIX LETS GET THIS MERGED ASAP :D thanks!

@ioannisj ioannisj mentioned this pull request Nov 19, 2024
Merged
11 tasks
@ioannisj ioannisj marked this pull request as ready for review November 19, 2024 16:30
@ioannisj ioannisj merged commit 769f762 into main Nov 19, 2024
6 checks passed
@ioannisj ioannisj deleted the fix/swift-ui-text-view branch November 19, 2024 18:24
eakurnikov pushed a commit to trustwallet/posthog-ios that referenced this pull request Feb 6, 2025
@ioannisj @eakurnikov
fix: detect and mask SwiftUI Text vs Image (PostHog#257)
4ff3064 
* fix: detect and mask SwiftUI Text respecting maskAllTextInputs

* chore: update CHANGELOG

* fix: changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SwiftUI Text view to be detected as a SwiftUI Image view
2 participants
@ioannisj @marandaneto