Skip to content

Fix crashes on disconnected pins in wmdks topologies. #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Fix crashes on disconnected pins in wmdks topologies. #300

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
496da67
Fix crashes on disconnected pins in wmdks topologies.
cme Sep 24, 2020
bdd8428
Fix potential assert on disconnected physical output pin in PinNew
cme Nov 18, 2020
8cc319b
Merge branch 'master' into cme-fix-wmdks-topology-crash
cme Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/hostapi/wdmks/pa_win_wdmks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,8 +1057,9 @@ static const KSTOPOLOGY_CONNECTION* FindStartConnectionFrom(ULONG startPin, PaWi
}
}

/* Some devices may report topologies that leave pins unconnected. This may be by design or driver installation
issues. Pass the error condition back to caller. */
PA_DEBUG(("FindStartConnectionFrom: returning NULL\n"));
assert(FALSE);
return 0;
}

Expand All @@ -1077,8 +1078,8 @@ static const KSTOPOLOGY_CONNECTION* FindStartConnectionTo(ULONG startPin, PaWinW
}
}

/* Unconnected pin. Inform caller. */
PA_DEBUG(("FindStartConnectionTo: returning NULL\n"));
assert(FALSE);
return 0;
}

Expand Down