Skip to content

style: smooth transition in profile tabs #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

AMIRKHANEF
Copy link
Member

@AMIRKHANEF AMIRKHANEF commented Nov 16, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced transition effects for the visibility of the Profile Tab, providing a smoother experience when toggling content.
  • Bug Fixes
    • Improved functionality of the account visibility toggle to ensure it only executes under specific conditions.

Copy link
Contributor

coderabbitai bot commented Nov 16, 2024

Walkthrough

The changes in ProfileTab.tsx focus on enhancing the transition effects of the Collapse component, specifically by adding a width transition to both the visible and hidden states. The transition properties have been updated to provide smoother visual feedback. Additionally, a modification was made to the hideAccounts function to ensure it only executes the showAccount function when the toHideAll parameter is defined.

Changes

File Path Change Summary
packages/extension-polkagate/src/popup/home/ProfileTab.tsx Updated transition properties for the Collapse component to include width transitions. Modified hideAccounts function to check if toHideAll is defined before executing showAccount.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProfileTab
    participant Collapse

    User->>ProfileTab: Toggle visibility
    ProfileTab->>Collapse: Update transition properties
    Collapse-->>ProfileTab: Apply width transition
    ProfileTab->>ProfileTab: Check toHideAll
    alt toHideAll defined
        ProfileTab->>Collapse: Show or hide accounts
    end
Loading

🐰 In the meadow, the transitions flow,
With width and shadows, a graceful show.
When accounts hide, a check is made,
Smoothly they vanish, in the glade.
Hopping along, we celebrate this change,
In our little world, nothing feels strange! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
packages/extension-polkagate/src/popup/home/ProfileTab.tsx (1)

Line range hint 28-29: Consider extracting transition constants

For better maintainability, consider extracting magic numbers related to transitions into named constants. This would make it easier to maintain consistent timing across different animations.

 const COLLAPSED_SIZE = '20px';
 const HIDDEN_PERCENT = '50%';
+const TRANSITION_DURATION = {
+  FAST: '0.2s',
+  NORMAL: '0.3s',
+  SLOW: '1s'
+};

 // Later in the code
 transition: visibleContent
-  ? 'width 0.3s, box-shadow 1s, opacity 1s'
-  : 'width 0.3s, box-shadow 0.2s, opacity 1s'
+  ? `width ${TRANSITION_DURATION.NORMAL}, box-shadow ${TRANSITION_DURATION.SLOW}, opacity ${TRANSITION_DURATION.SLOW}`
+  : `width ${TRANSITION_DURATION.NORMAL}, box-shadow ${TRANSITION_DURATION.FAST}, opacity ${TRANSITION_DURATION.SLOW}`

Also applies to: 96-96

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 455f1a5 and 14d7be4.

📒 Files selected for processing (1)
  • packages/extension-polkagate/src/popup/home/ProfileTab.tsx (1 hunks)
🔇 Additional comments (1)
packages/extension-polkagate/src/popup/home/ProfileTab.tsx (1)

96-96: LGTM! Smooth transition enhancement

The addition of the width transition property with a 0.3s duration provides a more polished animation when the tab expands/collapses. The timing is appropriate for a micro-interaction.

@Nick-1979 Nick-1979 merged commit 5a0b86b into PolkaGate:main Nov 17, 2024
8 checks passed
@AMIRKHANEF AMIRKHANEF deleted the styleTransition branch November 17, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants