Skip to content

[#101] Added front-default sprites for gen9 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

diduseetheocean
Copy link
Contributor

@diduseetheocean diduseetheocean commented Feb 2, 2023

Issue: #101

  • Added front_default sprites for generation 9 in pixelated style of B/W
  • Changed readme to include credits for the artist KingOfThe-X-Roads, who created these sprites

@diduseetheocean diduseetheocean force-pushed the feature/add-gen9-front-default-sprites branch from b89ef89 to d200f63 Compare February 2, 2023 17:27
@diduseetheocean
Copy link
Contributor Author

@Naramsim
For number 964, i included the hero-form of palafin. Maybe this isn't correct and it should be the zero-form.

@diduseetheocean
Copy link
Contributor Author

diduseetheocean commented Feb 3, 2023

@Naramsim
The sprites are currently not properly aligned inside the 96x96 canvas (to much left, right etc.) They should be aligned center-horizontally & center-vertically.

  • Fixed

@diduseetheocean diduseetheocean force-pushed the feature/add-gen9-front-default-sprites branch from d200f63 to 8e7febc Compare February 3, 2023 16:05
@FallenDeity
Copy link
Contributor

FallenDeity commented Feb 3, 2023

cut.zip normal ones
I have centred and sized the images appropriately here you can use them also for ones which u havent yet add like tatsugiri and u made a mistake with palafin kindly refer to official artwork of sprites when adding them I have already added those before in correct order
shiny.zip shiny ones

@diduseetheocean diduseetheocean force-pushed the feature/add-gen9-front-default-sprites branch from 8e7febc to 6438aa9 Compare February 3, 2023 19:46
@diduseetheocean
Copy link
Contributor Author

Added correct form of palafin for number 964.

@FallenDeity
I will not add the shiny ones here. In this PR i wanted only to add the front_default sprites.

@diduseetheocean diduseetheocean changed the title Added front-default sprites for gen9 [#101] Added front-default sprites for gen9 Feb 3, 2023
@FallenDeity
Copy link
Contributor

Added correct form of palafin for number 964.

@FallenDeity I will not add the shiny ones here. In this PR i wanted only to add the front_default sprites.

its not just those like lechonk iirc female form has id in around 10254 so some mons are misplaced those need a fix

@diduseetheocean diduseetheocean force-pushed the feature/add-gen9-front-default-sprites branch from 6438aa9 to 6aa4c1b Compare February 3, 2023 20:33
@diduseetheocean
Copy link
Contributor Author

@FallenDeity
Thx for your hint. I looked into your artwork PR and added/changed the sprites accordingly to match your structure.
Except i added the lechonk-female also into the female folder.
Plz have a look.

@FallenDeity
Copy link
Contributor

seems fine now main reason for the specific ids is to match the api data otherwise its gonna show up as null also if u have some time do consider adding the back defaults/shiny of few hiusian and gmax pokemon they seem to be missing

@diduseetheocean
Copy link
Contributor Author

diduseetheocean commented Feb 3, 2023

seems fine now main reason for the specific ids is to match the api data otherwise its gonna show up as null also if u have some time do consider adding the back defaults/shiny of few hiusian and gmax pokemon they seem to be missing

This could be done in another issue. Than this PR could be merged and closed.

@diduseetheocean
Copy link
Contributor Author

@Naramsim
Applied all changes. Rdy for review.

@devmike123 devmike123 self-requested a review February 5, 2023 04:34
Copy link
Collaborator

@devmike123 devmike123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing

@devmike123 devmike123 merged commit aa370b7 into PokeAPI:master Feb 5, 2023
@diduseetheocean diduseetheocean deleted the feature/add-gen9-front-default-sprites branch February 5, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants