-
Notifications
You must be signed in to change notification settings - Fork 5
Hack around Python 2 ASCII encoding bug / incompatibility #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also update the extra tests to limit the input to ASCII when necessary.
Bug: PythonCharmers/python-future#256 (This bug should only affect this test code.)
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
===========================================
- Coverage 95.83% 26.19% -69.64%
===========================================
Files 5 5
Lines 168 668 +500
Branches 26 112 +86
===========================================
+ Hits 161 175 +14
- Misses 4 488 +484
- Partials 3 5 +2
Continue to review full report at Codecov.
|
We seem to need this to get correct results.
Excellent! I wonder if vstinner/misc@a5f90a0#diff-b500f48c9778753dc97ebc453352f351R80 was not also about this.... I confirm that this now works correctly work with your fix using a degenerated locale! |
Hmm, I'm not sure what's up with the test coverage reporting. Something seems to be going wrong with the collection. :/ Running a coverage report locally gives the expected coverage, so I'm going to assume something with the CI integration is wonky; I'll go ahead and merge this, and worry about the CI reporting later. |
FWIW the coverage issue may be about how codecov merges reports from multiple runs in the CI matrix... |
And you even pushed this to Pypi... https://pypi.python.org/pypi/backports.os/0.1.1 Thank you very much! |
For context, see previous PRs #4 and #7.
This expands the test coverage to run against ASCII, adds a workaround for PythonCharmers/python-future#256 (which testing against ASCII runs into), and enables the hack for Python 2 ASCII (see comments).