Skip to content

Thread::Queue: clean up some tests #23121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Thread::Queue: clean up some tests #23121

merged 1 commit into from
Mar 19, 2025

Conversation

mauke
Copy link
Contributor

@mauke mauke commented Mar 15, 2025

Some of the tests (04_errs.t, 08_nothreads.t, 09_ended.t) already use Test::More unconditionally, so remove the conditional loading code from the other tests. Also, use Config doesn't need to be in a BEGIN block.


  • This set of changes does not require a perldelta entry.

Some of the tests (04_errs.t, 08_nothreads.t, 09_ended.t) already use
Test::More unconditionally, so remove the conditional loading code from
the other tests. Also, `use Config` doesn't need to be in a BEGIN block.
@tonycoz
Copy link
Contributor

tonycoz commented Mar 19, 2025

I don't see why not. t/test.pl only exists in the perl core. Anything installed from CPAN won't have access to it anyway.

Threads::Queue (and IO, threads.pm) bundle an old copy of test.pl in their CPAN distributions.

Porting/test-dist-modules.pl populates that with an old version (because blead's isn't compatible) when testing those modules.

Copy link
Contributor

@tonycoz tonycoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though looking at the test runs, dist-modules isn't using threaded perls when it should (looking into it)

@mauke mauke merged commit 7066fe7 into Perl:blead Mar 19, 2025
34 checks passed
@mauke mauke deleted the gumbo-7 branch March 19, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants