SC-85409 | Build and deploy demonstration previews on pull requests #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Alan-eMartin
force-pushed
the
sc-85409-v-demos-are-built-on-pull-request
branch
from
106578f to
2c2fa46
Compare
Alan-eMartin
commented
Apr 23, 2025
There was a problem hiding this comment.
Nice @Alan-eMartin! 🥳 Left a few questions/comments, but overall looks great.
Co-authored-by: Paul Finlay <[email protected]>
Co-authored-by: Paul Finlay <[email protected]>
rashidnhm
reviewed
Apr 28, 2025
rashidnhm
approved these changes
Apr 28, 2025
Thanks for the review @rashidnhm! No, not exactly. I will keep this in the Essentially we will no longer be using gatsby on the frontend, and will be replacing it with NextJS |
**Summary:** Allow internal users to build and deploy **all** or a select list of demos. **Related GitHub Issues:** Internal --------- Co-authored-by: Paul Finlay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
Summary:
This pull request uses the new
v2-build-demosandv2-deploy-demosworkflows to:Other changes:
Testing:
I was required to fork the QML repo to push these workflows to
masterasworkflow_runuses the workflow context frommaster.Therefore, you can take a look at the following ran actions:
https://github.com/Alan-eMartin/qml/actions