Arithmetic template qfunc decompositions #7779
Conversation
- how to account for modifiers?
comp-phys-marc
changed the title
comp-phys-marc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7779 +/- ##
==========================================
- Coverage 99.68% 99.68% -0.01%
==========================================
Files 540 540
Lines 55386 55575 +189
==========================================
+ Hits 55214 55402 +188
- Misses 172 173 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yeah when I created them I thought I would be doing refactors but as it turned out we just left the existing tape decompositions as they are... |
comp-phys-marc
changed the title
There was a problem hiding this comment.
This is optional, but maybe you can add a decomposition for "C(Adder)" (controlled Adder) that works by applying control only on the PhaseAdder in the middle? It is a nice trick because the QFT and the Adjoint(QFT) cancels out nicely when the middle PhaseAdder isn't applied. This will be significantly more resource efficient than the default, which is to apply control on every single op in the decomposition.
------------------------------------------------------------------------------------------------------------ **Context:** We would like the `ControlledSequence` to have a quantum function based decomposition that is compatible with the new decomposition system. **Description of the Change:** Adds a quantum function based decomposition and resource keys, params. **Benefits:** Makes the template compatible with the new system. **Possible Drawbacks:** **Related ShortCut Stories:** [sc-94491]
comp-phys-marc
changed the title
comp-phys-marc
changed the title
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Astral Cai <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
…to feature/template-refactoring
- Debug unrelated failure
- codecov hanging
Context: We would like to refactor our templates to use quantum functions in their decompositions in order to make them compatible with the new decompositions system.
Description of the Change: Base branch for arithmetic template refactoring, starting with Arithmetic templates.
Benefits: Allows us to decompose using decompositions that are program capture compatible. Tape based decompositions are still available as a backwards compatible fallback.
Possible Drawbacks:
Related ShortCut Story: [sc-95395]